Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonora Diamondback model grid loading incorrectly #122

Open
cwdix1 opened this issue Dec 17, 2024 · 1 comment
Open

Sonora Diamondback model grid loading incorrectly #122

cwdix1 opened this issue Dec 17, 2024 · 1 comment

Comments

@cwdix1
Copy link

cwdix1 commented Dec 17, 2024

I was having issues loading the new Sonora DB models using Sonora2024Grid(). Specifically, it kept returning 'AssertionError: Empty grid; parameter limits out of range'

The issue was resolved by adjusting line 85 in sonora.py.

OLD: fn = f"{base_path}diamondback_beta_spectra_m{Z_string}/t{teff}g{logg_par_dict[logg]}{fsed_string}_m{Z_string}_co1.0_std.spec"

NEW: fn = f"{base_path}t{teff}g{logg_par_dict[logg]}{fsed_string}_m{Z_string}_co1.0.spec"

Using this, I was able to load the full grid as I needed.

@Sujay-Shankar
Copy link
Collaborator

Hi Cooper:

Thanks for putting this here in Github! The issue's a pretty easy one, thankfully. Looks like the directory structure of the Diamondback models changed between the beta version and the public release. When I added Diamondback support, it was consistent with the beta directory structure. You made the right fix here, when I can I'll go in, update the code to reflect the new path, and close when completed.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants