Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starspot temperature slider appears to be not working in experimental Phoenix dashboard #85

Open
gully opened this issue Feb 23, 2023 · 5 comments
Assignees

Comments

@gully
Copy link
Member

gully commented Feb 23, 2023

When we change the starspot temperature, we see no change in either the component spectrum or the combined spectrum.

@Sujay-Shankar
Copy link
Collaborator

Hi gully! Could you share the grid parameters that you are using?

@gully
Copy link
Member Author

gully commented Feb 23, 2023

image

@Sujay-Shankar
Copy link
Collaborator

I think I've figured it out, the starspot temperature slider is hard locked to a maximum temperature of 4000K (why? i do not remember), but I'll just change it to span the same range as teff in the current branch I'm working on.

@Sujay-Shankar
Copy link
Collaborator

And since spot temp spectra only pull from the currently loaded grid, they can pull the closest grid point to 4000K, i.e. 4400K, and will only pull that spectrum. If you want lower temps, reduce teff range down to say 2300K.

@Sujay-Shankar
Copy link
Collaborator

The improvements branch now has the matched ranges for teff and spot_temp 👍
P.S. (the component spectra toggle was removed, now you can look at them by clicking on the interactive legend)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants