Replies: 1 comment 3 replies
-
I'd love to see the test-coverage improved for sure! In theory, I'd think there will be no change in performance at all, and hope that the code won't be less readable due to the abstraction than it is now. |
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
fyi, I have started to work on abstracting away jwalk to hide it behind an interface so that it is easily swappable by a mock implementation that will allow writing unit tests for
Traversal::from_walk
.Branch with work in progress implementation can be found here: https://github.com/gosuwachu/dua-cli/tree/dev/pwach/testing-traversal
From my initial tests, there doesn't seem to be much if any impact on the performance.
Beta Was this translation helpful? Give feedback.
All reactions