Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

injector: Repeat injection in case of failure and add proper exception handling #818

Open
psrok1 opened this issue Sep 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@psrok1
Copy link
Member

psrok1 commented Sep 13, 2023

Is your feature request related to a problem? Please describe.

injector isn't reliable as it interferes with processes already running in the system. We might be out of luck and get a trap being in the wrong place at the wrong time. These situations are usually one-time, so we should just repeat an injection few times until we get satisfying result.

It's especially important in draksetup postinstall step that makes dozen of injector -m readfile and single failure makes profile incomplete. In worst case it may fail at the beginning: #808. In that case, it's difficult to recover for newbie user from that situation as vm-0 is destroyed and we need to manually restore it and make another run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant