Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to handle long text #51

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MagMar94
Copy link
Contributor

@MagMar94 MagMar94 commented Nov 14, 2022

Closes #30

Makes it possible to truncate long text, or make it scroll in the allocated space.

The scrolling is based on this scrolling text generator. It is difficult to find the exact width of the text, but I found that multiplying the text length with 1,1 gives decent results. Some text will probably be longer, especially strings with lots og ms and wide characters. The current unit is ch, which is defined as the width of the character 0 (zero, or U+0030) of the font.

@MagMar94 MagMar94 force-pushed the feature/truncate-long-text branch from ab1399c to 489f3a1 Compare January 7, 2024 13:36
@MagMar94 MagMar94 force-pushed the feature/truncate-long-text branch 3 times, most recently from c85b727 to 08ae3e3 Compare January 7, 2024 13:52
…alue.

It will scroll only the information that is above the specified length.
If both artist- and track-info is to long, they will scrolle together.
@MagMar94 MagMar94 force-pushed the feature/truncate-long-text branch from 08ae3e3 to 47b077f Compare January 7, 2024 13:58
@MagMar94
Copy link
Contributor Author

MagMar94 commented Jan 7, 2024

It seems the css-is-up-to-date-check fails due to changes in the CSS.

Also, I'm having trouble running the project locally at the moment. For some reason the Sonos data is never received. As a result I have not been able to test the changes after the rebase. The socketclient.sendNotification(...) fires, but I dont't seem to get a response anymore. Anyway, I have no reason to believe the changes have broken since I opened the PR som I just fixed the conflicts. It should probably be tested before the PR is accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trim long titles
1 participant