-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runoff not conserved #231
Comments
I'm not sure what happens when JRA55do runoff is located at land points in the model. Need to find out what routing is done (if any). |
Also need to check whether conservative regridding is used - see #37 |
Maybe we'll need to set these in
|
In https://escomp.github.io/CMEPS/versions/master/html/addendum/req_attributes_cesm.html?highlight=rof2ocn_ice_rmapname#mediator-mapping-file-attributes it says CMEPS will create an "online route handle" if those values are unset. Whats the format of a "mapping file"? It looks like the default is to do a first-order conservative remapping: There are options for
I don't know if one of those makes more sense ? |
ESMF seems to support remapping with masks, so maybe we need to include a mask in our mesh files ? https://earthsystemmodeling.org/regrid/#options-for-masking-areas-unmapped-points-etc |
Thanks @anton-seaice, these (from https://earthsystemmodeling.org/regrid/#options-for-masking-areas-unmapped-points-etc) look like they may be suitable
or from CMEPS
|
@gustavo-marques - We (ACCESS) are looking at options for how to make sure runoff is distributed into the ocean (and not land). Does CESM use an 'online' computation for remapping weights? Or are you using pre-computed mapping weights? We are using this option for computing mapping weights online for liquid run-off: |
Hi @anton-seaice, eFold = smoothing eFold distance in meters (default: 1000000) You can find out more about this procedure here. |
Thanks @gustavo-marques, it's great to have these details |
It's possible #240 will play into this - our DROF mesh file doesn't contain any cell areas and the CDEPS is not expecting one either However we are definitely loosing lots of runoff in the mediator. From the mediator output, this is the difference between the rof and ocean diagnostics from the mediator. We gain run-off in some cells but no where near enough to equal the amount which disappears. Similarly the frozen runoff is mostly lost Most of the runoff is being masked out. If the runoff is masked using the landmask and compared to the amount entering the ocean, the different is very small (but non-zero!) And much closer to 0 in the frozen run off case |
We should prioritise fixing this, as it is blocking finalising the topography #172 (comment) |
@anton-seaice does it look like these tools will be suitable for us? https://github.com/ESMCI/cime/blob/master/tools/mapping/gen_mapping_files/runoff_to_ocn/README |
I am not sure, I think @kieranricardo has been trying something similar but different. I am planning on just trying one of these mapping options in the short term:
|
I think that changing the remapping option might not have the desired effect. All regridding methods conserve the total volume of water (at least where there is no masking), see So we don't need to worry about how the choice of regridding might impact overall water conservation They are also mask aware: However the total volume is not mapped on to unmasked cells - its mapped to all cells and then the mask is applied ( I think). (For example, there's nothing specified differently for rain which should be mapped to all cells vs runoff which only goes to ocean cells and lakes ). So the runoff mapped to land is still lost. It turns out there are two places to specify remapping relevant here.
Depending on the configuration - the runoff can be mapped onto land (and therefore lost) at either place. With our current set-up it's lost in the second step. When mapped in the mediator from the rof import to the ocn export. Changing the method in the mediator to There is no implementation [2] in CMEPS for nearest destination to source regridding which is possible in ESMF - maybe this is what we wan't. However its not clear that the "nearest destination" would only be an unmasked cells. |
It looks like there is a few ways of generating remapping run-off forcings:
GFDL has a method for producing remapped runoff files. It looks like this would produce a new version of the runoff file, with the runoff in the correct location for the provided grid. It seems to be based on the older mosaic grid format, so would need some work to be adapted to this circumstance. There is also this python package developed for ORA grids/models, which looks comprehensive but hasn't been updated in three years :
Or the online remapping using a kdtree, which could be implemented in the mediator
which looks ok but relies on grids in the SCRIP or pop-grid formats, so might need some adapting for us |
Thanks Anton - all good info. |
Runoff isn't conserved. Plots below show the RYF JRA55do input data and what is reported by MOM6 for a 1deg run (ignore "m-2" in the units).
The global integral of liquid runoff shows a significant shortfall in MOM6, especially in SH summer, but also (weirdly) excess water in late August. The step at 1 May is the RYF join.
MOM6 total_frunoff is drastically smaller than JRA55do licalvf
Plot script: https://github.com/aekiss/access-eval-recipes/blob/ef120fa/ocean/runoff_budget.ipynb
Related: #208 (comment), #217, #37, ACCESS-NRI/dev_coupling#33 (comment)
The text was updated successfully, but these errors were encountered: