Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROF and DATM stream names #27

Closed
aekiss opened this issue Aug 29, 2024 · 2 comments
Closed

DROF and DATM stream names #27

aekiss opened this issue Aug 29, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@aekiss
Copy link
Contributor

aekiss commented Aug 29, 2024

generate_xml_datm.py produces stream names like this

  <stream_info name="CORE_IAF_JRA55do.PRSN">

which is confusing, because CORE is a different dataset from JRA55do, and also the same stream names are also used for the RYF configs. Can we drop CORE_IAF_ and just have names like this?

  <stream_info name="JRA55do.PRSN">

Similarly, generate_xml_drof.py uses

  <stream_info name="rof.iaf_jra">

but

  <stream_info name="JRA55do.FRIVER">

(and similar for LICALVF - see #29) would be less confusing and more consistent.

@dougiesquire
Copy link
Collaborator

dougiesquire commented Aug 29, 2024

I think we can change these here, but CORE_IAF_JRA55do is actually the name of the new datamode that @ezhilsabareesh8 set up, so if we don't like that name we should change it here also.

UPDATE: opened COSIMA/access-om3#219

@dougiesquire
Copy link
Collaborator

Closed by #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants