Antenna deploy startup sequence #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makiv1
force-pushed
the
marko/ant-startup-sequence-i148
branch
from
90a243f to
c564ff4
Compare
… on startup. Deploys accordingly
Makiv1
force-pushed
the
marko/ant-startup-sequence-i148
branch
from
c564ff4 to
6d630c2
Compare
Makiv1
changed the title
DeflateAwning
changed the title
|
Would you mind explaining what edge cases this covers? E.g., corrupted file system (and how it handles it), antenna fails to deploy (and how it handles it), battery low (...), etc. Just want to make sure this gets a well-thought-out review and test plan to accompany it. |
|
Whoopsies, I see now that I was not as thorough I a should have been... I'll make sure that we are handling all of these in the pr on Thursday. |
Makiv1
added
pr-don't-review-yet
|
Ah sweet, thanks! I'm sure some of these are covered already; just wanted to understand what was here before I started reviewing the code :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #148
At the moment there is lots of logging messages. Perhaps too many...