Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 ADC: Monitor VBAT voltage with STM32 through voltage divider on OBC #175

Open
DeflateAwning opened this issue Sep 4, 2024 · 4 comments
Assignees

Comments

@DeflateAwning
Copy link
Contributor

  • Create telecommand which reports the VBAT voltage
@Freddydeddydoo Freddydeddydoo self-assigned this Nov 15, 2024
@Freddydeddydoo
Copy link
Contributor

Where would I put this in the telecommand defs.c? I don't think I should put this in the eps section because I don't think I need whatever external eps module to run this. I could be wrong.

@DeflateAwning
Copy link
Contributor Author

EPS telecommands file is probably fine. You'll also want to create a new function called something like EPS_read_vbat_with_adc, which could go in its own new file in the eps folder.

@Freddydeddydoo
Copy link
Contributor

I'm going to put the helper function of this telecommand in the eps_commands.h header file. I don't know if that's the best place to put it because I am just using Hal ADC functions and not really getting anything straight from the EPS. However, this function will only be used for the eps so that's why I'm putting it in there.

@DeflateAwning
Copy link
Contributor Author

Seems fine to me! Viable options are either in the EPS folder (maybe in a new file), or in the STM32 folder (e.g., where the "reset reason" files are). Not too concerned about where it goes though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants