ADCS commissioning #215
Open
ADCS commissioning #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T29F1G Series) (#177) * Replaced all flash driver code for NAND chip Replaced all previous code for FLASH driver for NAND flash module. * Updated memory module configuration Updated littlefs_helper.c configuration to use NAND memory module configuration values * Changes to flash_driver and flash_telecommand_defs Made changes to flash to handle full page reading and writing, added flash telecommand that unblocks block locks. * Minor changes to flash telecommands Minor changes to flash read hex telecommand for testing, added docstring for FLASH_reset function and telecommand. * Cleaned code from testing Removed all debugging printing lines to prepare for merging. Added new timeout variable for handling HAL_SPI transmits of 2176 bytes. * Removed Unblock_block_lock telecommand, Removed the telecommand unblock_block_locks and added automatic execution during write functions, minor changes to other flash telecommands. * Update LFS_benchmark_write_read to write many files * Fixed improper page addressing issue Fixed issue with improper page addressing where littlefs sent page address in bytes rather than the actual page address. * Minor changes based on PR review Removed unnecessary lines of code and added additional helpful comments based on PR comments * Updated littlefs benchmark test function Updated the littlefs benchmark write & read function to test both writing to the same file and to a new file. * Minor changes to fs benchmark file * Update littlefs_benchmark.c Added additional parameter in benchmark docstring. * Updated FLASH_MAX_BYTES_PER_PAGE Updated the naming and usage of variable FLASH_MAX_BYTES_PER_PAGE that keeps track of the maximum bytes per page for the FLASH NAND module. * Update flash_driver.h * Updated LFS_benchmark_write_read Updated name of LFS_benchmark_write_read_enum_t and added else statement for mode within function. --------- Co-authored-by: Saksham Puri <[email protected]> Co-authored-by: parker-research <[email protected]>
I might have to revert this commit in future.
DeflateAwning
added
the
pr-don't-review-yet
DeemDeem52
added
pr-please-review
|
There's still a bit of testing to be done with the CubeComputer, but I think the code is in a state where it should be reviewed for the sake of efficiency. |
|
(And I'll keep the 'save from SD' functions for the next PR, so there isn't too much to review this time) |
|
Is this a merge candidate, or did you just want a preliminary review? If it's ready to merge, would you mind changing it from a Draft to a regular PR? |
|
I want to do just a little more testing with it before I merge it, but once that's done (and since I don't anticipate any issues), it will be ready to merge -- so I'd like a review so that any issues are resolved before then and the merge can be nice and easy. |
|
We did our final testing of this PR's code today, ironing out the last few bugs. This PR is ready for review and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.