This all looks good. This just needs to be tested.

I was able to quickly test this using my NAND memory module. Looks good!
✅ Able to successfully delete a file if it exists.
✅ Reports appropriate error when trying to delete a file that doesn't exist.

Here are some things to consider that I found during testing (while not directly linked to the issue itself but worth getting investigated if possible):
⚠️ I'm unable to reach the "Error parsing file name arg" scenario when I send an empty string "" as an input. Also to note as a result "" is accepted as a parameter when creating a file. Able to reach case: 3 (filename too long for parsing) successfully.
⚠️ Able to send input both with and without "", are both ways acceptable? May be worth including in the arg doc so it is more clear.

This all looks good. This just needs to be tested.

I was able to quickly test this using my NAND memory module. Looks good! ✅ Able to successfully delete a file if it exists. ✅ Reports appropriate error when trying to delete a file that doesn't exist.

Here are some things to consider that I found during testing (while not directly linked to the issue itself but worth getting investigated if possible): ⚠️ I'm unable to reach the "Error parsing file name arg" scenario when I send an empty string "" as an input. Also to note as a result "" is accepted as a parameter when creating a file. Able to reach case: 3 (filename too long for parsing) successfully. ⚠️ Able to send input both with and without "", are both ways acceptable? May be worth including in the arg doc so it is more clear.

Thank you for testing! I'll take a look into the issues and get them fixed right away! Passing a filename argument of "" should not be acceptable, there should be an error case for an empty argument.

While looking through the code, I found that the "Error parsing file name arg" condition was trivial since passing no arguments to this telecommand prompts a telecommand parsing error. However, I will keep the statement in the code just to be safe.

I added a note in the doc string indicating to not add quotations around the argument when parsing fs_delete_file to reduce any confusion.

another good thing to mention is that it might be nice to wait until Saksham's LFS telecommand list files [issue #7] is merged into main to merge this branch. - PR #216