GPS: Send log command and receive log response from gps receiver #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherkinyua
added
requirement
DeflateAwning
added
pr-awaiting-testing
and removed
requirement
DeflateAwning
requested changes
Dec 3, 2024
| @@ -0,0 +1,144 @@ | |||
| #include "main.h" | |||
|
|
|||
| #include "debug_tools/debug_uart.h" | |||
There was a problem hiding this comment.
Please change file to indent using spaces.
There was a problem hiding this comment.
Changed my VS Code Preferences and saved the file. I dont see any changes after this. Can you elaborate if that is what you meant?
DeflateAwning
added
pr-awaiting-changes
and removed
pr-please-review
christopherkinyua
added
pr-please-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #246
Summary
This PR implements UART communication between the GNSS Receiver and the OBC. This includes transmitting a log command as a string and receiving a log response from the GNSS receiver
Changes Made
The changes made to realize this were as follows:
uart_handlerto receive the GNSS response in interrupt mode.GPS_set_uart_interrupt_stateto initialize UART communicationgps_internal_driversthat contains the function,GPS_send_cmd_get_response, that handles the communication with the GNSS receiver.TCMDEXEC_gps_send_log_cmdto call the function mentioned above.Testing Instructions
Tests were conducted on 28th November with @DeflateAwning and @NuclearTea present and we verified the functionality of the functions mentioned. Hence, the tests were successful.
Special Notes for Your Reviewer(s)
There are some
TODOandFIXMEtags within the code based on the current implementation that will need deeper looking into for proper functionality.