Problem while compiling the library

[xistocarlos]

Hi,

Im trying to compile the library on windows using Visual Studio and oneAPI. I run into the following error during the build:

[ 25%] Building CXX object CMakeFiles/ftorch.dir/ctorch.cpp.obj
ctorch.cpp
C:\Users\xisto\Documents\GitHub\gestpan_working_dir\FTorch-main\src\ctorch.cpp(224): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data
C:\Users\xisto\Documents\GitHub\gestpan_working_dir\FTorch-main\src\ctorch.cpp(229): error C2440: 'return': cannot convert from 'const T *' to 'const long *'
        with
        [
            T=int64_t
        ]
C:\Users\xisto\Documents\GitHub\gestpan_working_dir\FTorch-main\src\ctorch.cpp(229): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" -E cmake_cl_compile_depends --dep-file=CMakeFiles\ftorch.dir\ctorch.cpp.obj.d --working-dir=C:\Users\xisto\Documents\GitHub\gestpan_working_dir\FTorch-main\src\build --filter-prefix="Note: including file: " -- C:\PROGRA~1\MIB055~1\2022\COMMUN~1\VC\Tools\MSVC\1442~1.344\bin\Hostx64\x64\cl.exe @C:\Users\xisto\AppData\Local\Temp\nmCE3F.tmp' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\bin\HostX64\x64\nmake.exe" -s -f CMakeFiles\ftorch.dir\build.make /nologo -SL                 CMakeFiles\ftorch.dir\build' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\bin\HostX64\x64\nmake.exe" -s -f CMakeFiles\Makefile2 /nologo -LS                 all' : return code '0x2'
Stop.

Any ideas?

[xistocarlos]

I managed to find a solution in one of the fixes:

https://github.com/Cambridge-ICCS/FTorch/pull/191/files#diff-37ba47fab4c276181f2ff8a040bd113f3a4e9f1951fc69c660bbb1f7a86e49e4

[jatkinson1000]

Hi @xistocarlos That's great, and thanks for updating.

As you spotted, this is an issue we are aware of and are currently working to patch.
Once we are satisfied that that branch is passing all tests and is a robust fix we will be merging it into the main branch.
Hopefully this should be within the next couple of weeks.

Windows can be quite fickle, but we are also looking at setting up a Windows test suite in GitHub to keep a better overview on this.

[jatkinson1000]

@xistocarlos just to let you know that all of the Windows updates are now merged into the main branch, so you should be able to build using that going forward.

[xistocarlos]

Thank you! Much appreciated

…

________________________________ From: Jack Atkinson ***@***.***> Sent: Tuesday, December 10, 2024 5:50:24 PM To: Cambridge-ICCS/FTorch ***@***.***> Cc: Carlos Xisto ***@***.***>; Mention ***@***.***> Subject: Re: [Cambridge-ICCS/FTorch] Problem while compiling the library (Discussion #196) @xistocarlos<https://github.com/xistocarlos> just to let you know that all of the Windows updates are now merged into the main branch, so you should be able to build using that going forward. — Reply to this email directly, view it on GitHub<#196 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJPKZPUUNC7SKSBIYBE77GT2E4LVBAVCNFSM6AAAAABSSJCQYGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCNJSGM3DIMA>. You are receiving this because you were mentioned.Message ID: ***@***.***>