Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensor event - measurement type? #10

Open
ghost opened this issue Jun 18, 2019 · 2 comments
Open

Sensor event - measurement type? #10

ghost opened this issue Jun 18, 2019 · 2 comments
Assignees

Comments

@ghost
Copy link

ghost commented Jun 18, 2019

Just noticed (I'm a little slow! :-)) that the sensor measurement event doesn't include a "type". Method is there but it might be handy to have type just in case the same method is used multiple times e.g. in a device the records high and low temperatures.

    "measurement": {
        "id": 129,
	"method": "thermometer",
        **"type": "temperature",**
	"scale_name": "Celsius",
        "value": 27.5
    }, ...
    "measurement": {
        "id": 129,
	"method": "thermometer",
        **"type": "high_temp_last_hour",**
	"scale_name": "Celsius",
        "value": 27.5
    },

Might be worth considering a taxonomy of known types too.

What do you think?

@alanepaull alanepaull reopened this Jun 25, 2019
@alanepaull alanepaull self-assigned this Jun 25, 2019
@alanepaull
Copy link
Contributor

measurement.type exists; measurement_taxonomy revised for clarity. Above example can be handled in current implementation, though we would need to enable extension to the taxonomy. I suspect that we need to permit on-the-fly types here, owing to the variety of stuff out there.

Should I revise the taxonomy to suggest that this can be extended by locally determined values if required? Then, the listed ones are simply there to map to, if appropriate, or as examples, but not prescriptive.

@ghost
Copy link
Author

ghost commented Jul 3, 2019

Should I revise the taxonomy to suggest that this can be extended by locally determined values if required?

Yes - I think we have to allow for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant