Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in Upserting of Events #177

Open
tushar5526 opened this issue Oct 18, 2023 · 1 comment · May be fixed by #178
Open

Bugs in Upserting of Events #177

tushar5526 opened this issue Oct 18, 2023 · 1 comment · May be fixed by #178

Comments

@tushar5526
Copy link
Contributor

tushar5526 commented Oct 18, 2023

1. Upsert not working

  • Currently, upsert is not working and ingestion is creating multiple dimensions keys for events.

Reproduce as following

yarn cli ingest
yarn cli ingest-data
yarn cli ingest-data

Check Hasura now.

2. Event Grammars should not be needed while upserting

yarn cli ingest
  • Remove all the grammar files from ingest folder
yarn cli ingest-data

3. Allow ingestion of some events only

  • After ingestion of grammar files, I should be able to ingest data for some events only. For example if I have 5 events, and only specify 3 event data files, cQube should ingest the 3 event files and consider no event data for the rest 2 events. It can print a warning saying No event data files for event <eventName>
@techsavvyash techsavvyash linked a pull request Oct 19, 2023 that will close this issue
3 tasks
@techsavvyash
Copy link
Collaborator

#178 aims to solve for this, tests have been added in the PR as requested and here is a small SR link showing the working of ingest-data with upsertion after applying the patch in #178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants