Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOFMM's adaptive level restriction may not be working correctly #24

Open
ChenhanYu opened this issue Jan 19, 2019 · 3 comments
Open

GOFMM's adaptive level restriction may not be working correctly #24

ChenhanYu opened this issue Jan 19, 2019 · 3 comments
Assignees
Labels

Comments

@ChenhanYu
Copy link
Owner

Adaptive level restriction requires inspection or fix.

@ChenhanYu ChenhanYu added the bug label Jan 19, 2019
@ChenhanYu ChenhanYu self-assigned this Jan 19, 2019
@ChenhanYu
Copy link
Owner Author

Now by default, secure_accuracy (level restriction) is on. I will carry out the new command line parser.

@ChenhanYu
Copy link
Owner Author

Notice that when the leaf is not skeletonized, securing the accuracy will change the near interaction list. That is all leaf nodes that cannot be skeletonized must be also be added to all other's near interaction lists. To avoid this problem, when secure accuracy is turned "on" we will force the leaf node size to be not larger than the maximum rank.

@ChenhanYu
Copy link
Owner Author

ChenhanYu commented Jan 30, 2019

secure_accuracy now works correctly on both shared and distributed GOFMM. You can set this option in CommandLineHelper. This option will be propagated to the other scripts in the following update.
#36 shares the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant