Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving how we sample indices to test to avoid hard-coding #39

Open
JamesLevitt opened this issue Mar 6, 2019 · 2 comments
Open

Improving how we sample indices to test to avoid hard-coding #39

JamesLevitt opened this issue Mar 6, 2019 · 2 comments
Assignees
@ChenhanYu
Labels
bug enhancement

Comments

@JamesLevitt
Copy link
Collaborator

This line in gofmm::SelfTesting sets the target index to 1000 * i, where 0 <= i < ntest. LaunchHelper calls SelfTesting with ntest = 100, which triggers a segfault if the matrix has fewer than 100k rows.

This issue was fixed before here and reintroduced here. I suggest changing it back or doing something else that doesn't involve hardcoding indices.
@JamesLevitt JamesLevitt added the bug label Mar 6, 2019
@JamesLevitt JamesLevitt changed the title gofmm.hpp segfault gofmm::SelfTesting Segfault Mar 6, 2019
@ChenhanYu ChenhanYu self-assigned this Mar 6, 2019
@ChenhanYu
Copy link
Owner

I agree. I have fixed this issue at e99a655.

@ChenhanYu ChenhanYu changed the title gofmm::SelfTesting Segfault Improving how we sample indices to test to avoid hard-coding Mar 6, 2019
@ChenhanYu ChenhanYu reopened this Mar 6, 2019
@ChenhanYu
Copy link
Owner

I will keep it opened to make sure I work on improving it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChenhanYu ChenhanYu

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamesLevitt @ChenhanYu