-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mic and Camera toggles broken in recent Meet update #49
Comments
Hmm, for me it's still the old |
FYI. I believe that is due to an update to Meet, not Chrome. |
Yes, my mistake! :face_palm: |
If anyone wants to try the sept-2024-redesign branch, I added the button IDs @Jbossalini provided, so it should work with both the old and new Meet buttons. I'm unable to test it myself though until the Meet update makes its way to my own Google account. |
works for me! thanks for the quick update! |
NVM: I must be misrememberingI think it worked before where I could mute/unmute even if I was on another tab (and the Meet tab wasn't the focus), and it doesn't when testing this fix. I'll re-try with removing the OR in queryselector and see if that makes a difference. |
I'm not sure if this is related but my "Toggle Chat" button is also no longer working |
@ccseifert Do you have the Round buttons or Square buttons? I think there is more than one update out in the wild, because I still have the Round buttons, but it was only the Mic and Camera selectors that changed for me. Chat still works. https://workspaceupdates.googleblog.com/2024/06/updated-design-for-meeting-controls-google-meet.html Can you grab the |
@Jbossalini I have the "after" from your two screenshots. My jsname is the same as yours, "A5il2e" |
what about |
data-panel-id="2" |
oh, yeah, that's because you are just on the landing page for Meet. Trash the errors on that screen, and then open a full Meet and check again. |
I finally started seeing the new layout. The jsnames for the camera and mic buttons are still the old ones for me. All buttons still work for me, even with the new styling.
It should work regardless of tab or window state, and still does for me. Do you have any of those "resource saver" / "tab suspender" extensions that pause script execution when the tab is out of focus? @ccseifert It looks like you're running an older version of the browser extension. Please update to the latest release and try again. (That error is on line 72, but the entire file was refactored and fixed a couple months ago and is now only 20 lines long total.) |
@ChrisRegado who knows what Google is doing because now since yesterday I have some combination of round and square buttons ¯_(ツ)_/¯ (using the new jsnames I reported earlier) EDIT: Oh wait, that is the new layout I also get the pop-out window now for a Meet session, and the extension works with that, too, which is good to see.
Ok, great! Thanks for confirming the behavior. I will spend some time testing with/without other extensions and see if I can narrow it down. Of course, as mentioned above, with the new pop-out window for Meet, it's not a huge issue anymore 😁 |
Works for me! Thanks. |
The |
I came searching for a solution to my issues with the chrome extension, and I noticed the same issue could be replicated on windows, but on intel based mac, everything works fine. On windows, I'm using the sept-2024-redesign branch, chrome version 130.0.6723.71. On mac, it's the sept-2024-redesign branch, chrome version 129.6668.91. I'm not very knowledgeable about chrome extensions, but if there's any more info I can provide that would be helpful, please let me know! |
I merged in the sept-2024-redesign branch. It's included in release v1.5.1. On my own Google account, the old extension (v1.5.0) without any of the sept-2024-redesign changes still works fine, so there must be some changes from Google that are not yet available to me. But since the branch works for several people in this thread while remaining backward compatible, it seems worth trying. |
@tylernewcomb I've tested v1.5.1 on both macOS and Windows, so it should work on both. (The browser extension is generally platform agnostic.) Do any of the buttons work for you on Windows (Leave Call, Toggle Chat, etc), or is it just the mic and camera buttons that are broken? |
@ChrisRegado the end call button, raise hand, and thumbs up all worked for me. I could not get the microphone or camera buttons to work, whether it was toggle or mute/unmute buttons. |
@tylernewcomb In your Chrome Extensions page, does it show you're running v1.5.1? (It should be the same version number for the sept-2024-redesign branch as well.) If not, I'd suggest trying to start fresh: uninstall the extension from Chrome, delete the files, and then install the latest v1.5.1 release using the normal instructions. And if all of that fails, you may have some new variant of the Meet interface from Google that we haven't seen yet, in which case a fix will be much more complex. We'd need to find the |
Ah yes, I was running 1.5.0 on the Windows machine. Installing 1.5.1 fixed the issue. I could have sworn it was the same version on both, but oh well. Thanks for the help, the plugin is great! |
Nice, this release solved my "open chat" button not working as well. Thanks! |
Looks like the
jsname
for the Mic and Camera toggle button changed in a recentChromeMeet update.(I'm on 129.0.6668.59 currently)Anyway, I don't have time yet to create a Pull request but, new selectors are:
mic_event_handler.js:
return document.querySelector('div[jsname="Dg9Wp"] [jsname="hw0c9"]');
camera_event_handler.js:
return document.querySelector('div[jsname="R3GXJb"] [jsname="psRWwc"]');
The text was updated successfully, but these errors were encountered: