Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure behavior DSCIM depends on is covered by good unit tests #479

Open
brews opened this issue Jul 20, 2023 · 2 comments
Open

Ensure behavior DSCIM depends on is covered by good unit tests #479

brews opened this issue Jul 20, 2023 · 2 comments

Comments

@brews
Copy link
Member

brews commented Jul 20, 2023

dscim is a downstream dependency of this package. This package has some spotty test coverage in places. It would be great is we could double check, and if need be, write in unit or integration tests to cover the behavior that dscim depends on.

@brews
Copy link
Member Author

brews commented Jul 20, 2023

@kemccusker could I get your help and have you take this or collaborate and help look at this problem on the dscim end of things. I'd like to ensure we have good enough tests to not accidentally break something dscim depends on.

@brews
Copy link
Member Author

brews commented Jul 20, 2023

In dscim v0.4.0 is looks like this weighted_quantile_xr() function gets called. We'll want to ensure it gets tested, especially when the input data is a xr.Dataset. On quick look through the coverage information we have online, it doesn't look like that's the case.

I also haven't looked to see what existing tests run the function for or if they're even checking it's behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant