Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out Travis CI for Github Actions, enable testing on PRs #107

Closed
brews opened this issue Jun 16, 2022 · 5 comments · Fixed by #126
Closed

Swap out Travis CI for Github Actions, enable testing on PRs #107

brews opened this issue Jun 16, 2022 · 5 comments · Fixed by #126
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@brews
Copy link
Member

brews commented Jun 16, 2022

Travis CI has been disabled for the org. This repo has an old Travis CI config that needs to get swapped out for Github Actions.

I think the minimum requirement is that tests (comparable to that running on Travis CI) run on Pull Requests, using the latest Python 3 release?

There is quite a bit of legacy code and configurations and cruft here so we might need to feel this out a bit more.

@brews brews added the bug Something isn't working label Jun 16, 2022
@brews
Copy link
Member Author

brews commented Jun 16, 2022

I can take lead on this.

Going to try to do a repo or two every day, to do low-burn maintenance on all our repos. This repo is relatively higher priority because people use the package regularly. There is quite a bit of old legacy stuff here, including python 2.x support. Might be a good idea to simplify the repo whizbangs until things are easier to maintain, enable dependabot, etc.

Also need to think about how CI should interact with readthedocs, and how releases get pushed to pypi securely. These will likely need to be separate issues.

Notifying @delgadom, because he's listed as maintainer on this. I don't know if you have any thoughts, ideas, or concerns?

@brews brews self-assigned this Jun 16, 2022
@delgadom
Copy link
Member

all that sounds good. generally I think the more simplification the better, even at the expense of some functionality. if things break I'll fix it

@delgadom
Copy link
Member

if you want to switch to github pages or even nodocs I think that's not the end of the world. I don't think anyone external uses this

@brews
Copy link
Member Author

brews commented Jun 16, 2022

Cool cool.

@delgadom Would you be up for reviewing a couple of PRs to play with some ideas and see how it feels to you with some basic cleanup? (Then I can plow forward and apply similar updates to the other small/mid repos).

@brews
Copy link
Member Author

brews commented Jul 18, 2023

Tracking the rest of the cleanup we talked about over in #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants