Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Selection highlight overflow is drawn just above bottom viewport edge #7

Closed
austincondiff opened this issue Dec 20, 2023 · 0 comments · Fixed by #27
Closed

🐞 Selection highlight overflow is drawn just above bottom viewport edge #7

austincondiff opened this issue Dec 20, 2023 · 0 comments · Fixed by #27
Labels
bug Something isn't working

Comments

@austincondiff
Copy link
Contributor

austincondiff commented Dec 20, 2023 •
edited
Loading

Description

When selecting text beyond the bottom edge (top is fine), the selection highlight is drawn just above the bottom edge.

To Reproduce

  1. Select multiple lines of text
  2. Scroll up so that selection highlight exceeds the bottom edge of the text view viewport.

Expected Behavior

Selection highlight is drawn flush with the bottom edge of the text view viewport.

Version Information

CodeEditTextView: 0.7.0
macOS: 14.0
Xcode: 15.0

Screenshots

image
@austincondiff austincondiff added the bug Something isn't working label Dec 20, 2023
@austincondiff austincondiff changed the title 🐞 Selection highlight overflow is drawn just above edge 🐞 Selection highlight overflow is drawn just above bottom viewport edge Dec 20, 2023
@danielzsh danielzsh mentioned this issue May 3, 2024
Merged
6 tasks
@thecoolwinter thecoolwinter moved this from 🆕 New to 📋 Todo in CodeEdit Project May 11, 2024
@github-project-automation github-project-automation bot moved this from 📋 Todo to 🏁 Complete in CodeEdit Project May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
CodeEdit Project
Status: 🏁 Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove insets from scroll view danielzsh/CodeEditTextView
1 participant
@austincondiff