Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Wrapper #148

Open
rishi058 opened this issue Jul 1, 2023 · 8 comments
Open

Responsive Wrapper #148

rishi058 opened this issue Jul 1, 2023 · 8 comments

Comments

@rishi058
Copy link

rishi058 commented Jul 1, 2023

Why responsive wrapper.builder is not working in the new version.
How to use responsive wrapper globally then?

@chungonion
Copy link

I have no idea why this is treated as 1.1.0, as it breaks everything and should be a 2.0.0 instead

@Muhammadtawil
Copy link

i have the same problem , package doc not help

@MuhammadFarrelFaiz
Copy link

i have the same problem too

@egonbeermat
Copy link

egonbeermat commented Aug 14, 2023

I struggled to get 0.2.0 working for me based on the supplied documentation, but managed to get something that worked well for my application, and I was really happy with what the package provided, thank you!

I don't like to let packages "age" significantly in releases, so I looked into 1.1.0 - and it appears to function in a completely different way. It would be helpful if there was more documentation on migrating from 0.2.0 to 1.1.0, on how to recreate the exact same result from each version, perhaps using the example given in 0.2.0 and recreating the same effect in 1.1.0. Two of the three demos on the pub.dev page still use the old version, so that's not helpful for migration.

It's not clear to me in the 1.1.0 version what replaces, or how to implement, the following from ResponsiveWrapper.builder:

minWidth
minWidthLandscape
defaultScale
defaultScaleLandscape
breakpoints [...]
breakpointsLandscape [...]

It also isn't clear how to implement this when using named routes; previously, ResponsiveWrapper could be returned from the builder of MaterialApp and it was all good, but now that there are two separate widgets involved (ResponsiveBreakpoints, ResponsiveScaledBox) and it's not clear to me how to use these in the context of named routes, vs onGeneratedRoute.

Further migration documentation from 0.2.0 would be helpful. For now, I'll stick to 0.2.0 but eventually, if I am later forced to move to the new implementation, I'd have to consider alternative packages in the mix as I'd be effectively implementing a completely 'new' package with a different paradigm, going from 0.2.0 to 1.1.0

@rayliverified
Copy link
Contributor

Thank you for your patience. Migration guide is up!

https://github.com/Codelessly/ResponsiveFramework/blob/master/migration_0.2.0_to_1.0.0.md

@rayliverified
Copy link
Contributor

I have no idea why this is treated as 1.1.0, as it breaks everything and should be a 2.0.0 instead

Apologies for the huge breaking change. The prior version was v0.2.0 so I thought the big change was appropriate for a V1 release.

I can see the confusion and will keep this in mind for the future.

@egonbeermat
Copy link

Thanks! I'm in the middle of a set of changes to my app, so I'll take a look at this in a week or two and give feedback.

@chungonion
Copy link

chungonion commented Sep 12, 2023

I have no idea why this is treated as 1.1.0, as it breaks everything and should be a 2.0.0 instead

Apologies for the huge breaking change. The prior version was v0.2.0 so I thought the big change was appropriate for a V1 release.

I can see the confusion and will keep this in mind for the future.

Thanks for the guide! I will take a look in the coming days, please keep your good work 😄

Why i was making that 2.0 comment is that I have migrated from 0.2 -> 1.0 , and I found a number of changes that have broke my app. I follow some of those PRs/issues and I was able to migrate everything. And then once again on 1.0 -> 1.1 it breaks again, was thinking of how to migrate but this time I don't have that much of information available on one hand, and also some of the core feature is just not there that I was relying on the previous versions. Thanks anyway, it is a great library :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants