Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client ID to Query messages to allow peers to identify them? #416

Open
mikera opened this issue Oct 4, 2022 · 2 comments
Open

Add client ID to Query messages to allow peers to identify them? #416

mikera opened this issue Oct 4, 2022 · 2 comments
Labels
question Further information or discussion is requested
Milestone

Comments

@mikera
Copy link
Member

mikera commented Oct 4, 2022

It would be potentially valuable to add extra identifying information to queries to allow peers to distinguish between clients. Plausible reasons:

  • charge costs for computation
  • offer better QoS to subscribers

Would require some sort of Auth, probably a signature on queries.

Unidentified queries would still be possible, but Peers could give them lesser / no QoS

@mikera mikera added the question Further information or discussion is requested label Oct 4, 2022
@mikera mikera added this to the Gamma milestone Oct 4, 2022
@mikera mikera changed the title Add client ID to Query messages to allow peers to offer QoS on query usage Add client ID to Query messages to allow peers Oct 4, 2022
@mikera
Copy link
Member Author

mikera commented Oct 4, 2022

Could have an overridable method in Server e.g. shouldAllowQuery

@helins
Copy link
Member

helins commented Dec 19, 2022

A similar shouldAllowTransaction is also desirable for the same reasons.

Unlike queries, transactions are signed by users. Thus, a client ID (or similar) is not strictly required but it might be more convenient in some situations.

@mikera mikera changed the title Add client ID to Query messages to allow peers Add client ID to Query messages to allow peers to identify them? Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information or discussion is requested
Projects
None yet
Development

No branches or pull requests

2 participants