Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently use segment names from DB for frontend/templates #1668

Open
dchiller opened this issue Oct 15, 2024 · 0 comments
Open

Consistently use segment names from DB for frontend/templates #1668

dchiller opened this issue Oct 15, 2024 · 0 comments
Labels
priority: medium

Comments

@dchiller
Copy link
Contributor

Introduced in #1607. A current pattern in the code is to test a source for a segment ID and then hardcode the "name" of that segment in templates and views. As we switch to a one-to-many source segment field and the number of segments proliferate, this is unsustainable. We should consistently name and refer to segments in the frontend through use of the Segment model.
dchiller added a commit to dchiller/CantusDB that referenced this issue Oct 15, 2024
@dchiller
fix(institution detail): show colloquial name if exists
147c0f4 
Change hardcoded name for Bower segment sources. This will be modified as part of our segment overhaul (see DDMAL#1668)
@dchiller dchiller mentioned this issue Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dchiller