You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This requirement is currently tested in the form_valid method of the ChantCreateView. It is not tested at all for any other chant editing methods (either the Admin panel or the ChantEditView), and indeed, this method is the wrong place for this kind of validation (the validation should occur on the form and not on the view). Eventually, this would be a good place for a uniqueness constraint on the model itself, but there is messy data currently.
We'll use #1714 to fix this data and then add a model uniqueness constraint. In the meantime, I'll move these validations to a form method.
The text was updated successfully, but these errors were encountered:
dchiller
changed the title
Chant edit: uniqueness requirement for folio-sequence is not tested
Source-folio-sequence uniqueness requirement
Nov 21, 2024
dchiller
added a commit
to dchiller/CantusDB
that referenced
this issue
Nov 21, 2024
This requirement is currently tested in the
form_valid
method of the ChantCreateView. It is not tested at all for any other chant editing methods (either the Admin panel or the ChantEditView), and indeed, this method is the wrong place for this kind of validation (the validation should occur on the form and not on the view). Eventually, this would be a good place for a uniqueness constraint on the model itself, but there is messy data currently.We'll use #1714 to fix this data and then add a model uniqueness constraint. In the meantime, I'll move these validations to a form method.
The text was updated successfully, but these errors were encountered: