Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel.js: Remove "max 2 inputs" line in alert message. #84

Open
cadagong opened this issue May 2, 2023 · 2 comments · May be fixed by #82
Open

Pixel.js: Remove "max 2 inputs" line in alert message. #84

cadagong opened this issue May 2, 2023 · 2 comments · May be fixed by #82
Assignees

Comments

@cadagong
Copy link

cadagong commented May 2, 2023

No description provided.

@cadagong cadagong self-assigned this May 2, 2023
@cadagong cadagong transferred this issue from DDMAL/Rodan May 22, 2023
@PythonSemicolon
Copy link

@martha-thomae do you remember the details of this issue? David and I seem to think it had to do with the input layers from the Rodan job ports, but we can't remember exactly what the problem was nor can I find the specific alert in the Pixel code. It seems to have been raised during your presentation in training week.

@PythonSemicolon PythonSemicolon self-assigned this Jun 1, 2023
@martha-thomae
Copy link

Oh, yes, I think this refers to the window that appears on pixel when you click on the black box (the black pixel), where it reads:

Screenshot 2023-06-02 at 6 30 41 PM

We need to remove the second line: "This must be two (2) less than the total number of output ports." This line is based on how things worked on pixel-Rodan before, but that is not the case anymore. So just remove that line and leave the question about how many layers to classify and the text box for the user to confirm.

By the way, I think this window only appears when you don't provide any input ports. When you do provide the input ports, this window doesn't appear at all (which is good and makes sense!)

@PythonSemicolon PythonSemicolon transferred this issue from DDMAL/Pixel.js Jun 5, 2023
@PythonSemicolon PythonSemicolon linked a pull request Jun 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants