You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When attempting to use this action elsewhere, i realized my testcases were faulty; resulting in this action never actually working until the latest release of v1.0.4 where the build is directly accessible.
The fix
As a quick fix, I've directly included the build into the repo. This is not great, I'd rather the build only be distributed with each release. Will explore options. Additionally, implementing this hot-fix included an enviroment shift to running under straight nodejs12, instead of a docker container; shaving off nearly 20s of run-time(since no container was spun up).
Origin
When attempting to use this action elsewhere, i realized my testcases were faulty; resulting in this action never actually working until the latest release of
v1.0.4
where the build is directly accessible.The fix
As a quick fix, I've directly included the build into the repo. This is not great, I'd rather the build only be distributed with each release. Will explore options. Additionally, implementing this hot-fix included an enviroment shift to running under straight
nodejs12
, instead of a docker container; shaving off nearly20s
of run-time(since no container was spun up).Resources
ncc
The text was updated successfully, but these errors were encountered: