[ec2] reset password on Windows VMs #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was breaking as the password can contain special chars
KevinFairise2
approved these changes
Sep 30, 2024
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
KevinFairise2
added a commit
that referenced
this pull request
Oct 1, 2024
This reverts commit 85c56b4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reset password and configure it to a random string at init time
Which scenarios this will impact?
EC2 on Windows
Motivation
EC2 configures Windows hosts with a random password. The password is base64 encrypted with the public SSH key, to decrypt it we would need to first decrypt the private SSH key that is passphrase protected on our laptops, then decrypt the key. As this has multiple potential points of failure, and it would require storing the private key password somewhere accessible, it is quicker to reset the password through SSH once we are connected to the VM, at init time.
This allows for any code creating a
NewVMon Windows to have a proper, accessible password in theRemoteHostoutput.It is safe to print it in our CI logs as the instance is protected behind our network.
Additional Notes
Tested on datadog-agent, the only failure is not related to the change, the test failed on
maintoo