Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo-server-core shouldn't be required to run this package. #239

Open
dbousamra opened this issue Sep 13, 2021 · 1 comment
Open

apollo-server-core shouldn't be required to run this package. #239

dbousamra opened this issue Sep 13, 2021 · 1 comment

Comments

@dbousamra
Copy link

As per title, if you don't have this peer dependency, regardless of using federation or not, this module will not load.

@Davide-Gheri
Copy link
Owner

This library is still using the official @nestjs/graphql lib to do a lot of stuff, and that library unfortunately depends on apollo-server-core.

There is an open issue on @nestjs/graphql to isolate schema-generation stuff and server-specific stuff, but it's not a top priority for them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants