Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Icon size for button #74

Closed
Sabrinavigil opened this issue Jul 21, 2022 · 1 comment · Fixed by #75
Closed

bug: Icon size for button #74

Sabrinavigil opened this issue Jul 21, 2022 · 1 comment · Fixed by #75
Assignees
@daniel-dumortier
Labels
bug 🐛 Something isn't working

Comments

@Sabrinavigil
Copy link

For medium button, the icon size is 16. The good size is 20.
And for large button, the icon size is 16. The good size is 24.
@Sabrinavigil Sabrinavigil added the bug 🐛 Something isn't working label Jul 21, 2022
@daniel-dumortier
Copy link
Contributor

Since I am working on button with single icon, I will include this fix in the PR.

@daniel-dumortier daniel-dumortier self-assigned this Jul 22, 2022
@florentlotthepro florentlotthepro mentioned this issue Jul 22, 2022
Merged
7 tasks
@florentlotthepro florentlotthepro linked a pull request Jul 22, 2022 that will close this issue
feat(button): add icon alone UIKit VitaminButton type, and refactor icon management #75
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-dumortier daniel-dumortier

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@daniel-dumortier @Sabrinavigil