Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: UIKit Vitamin buttons dimensions are not exact compared to Figma #77

Open
daniel-dumortier opened this issue Jul 26, 2022 · 0 comments
Open

bug: UIKit Vitamin buttons dimensions are not exact compared to Figma #77

daniel-dumortier opened this issue Jul 26, 2022 · 0 comments
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community UIKit

Comments

@daniel-dumortier
Copy link
Contributor

Describe the bug

Button in UIKit implementation do not match the size of Buttons in Figma (see below).
It might be linked to wrong padding and insets.

New icon alone button are not concerned by this bug

Steps to reproduce

  1. Go to UIKit part of Showcase
  2. Click on "Buttons"
  3. take a screenshot
  4. overlay Figam buttons
  5. See differences

Expected behavior

Button dimension should match exactly Figma button

Screenshots

Capture d’écran 2022-07-26 à 15 09 22

Device (please complete the following information):

  • Model: iPhone
  • OS: iOS
  • Version : N/A
@daniel-dumortier daniel-dumortier added the bug 🐛 Something isn't working label Jul 26, 2022
@daniel-dumortier daniel-dumortier mentioned this issue Jul 26, 2022
Merged
7 tasks
@florentlotthepro florentlotthepro moved this from 🆕 New to 🔖 Dev to do in Decathlon Design System Dec 8, 2022
@lauthieb lauthieb removed the run 💨 label Apr 7, 2023
@mackoj mackoj added the community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community UIKit
Projects
Decathlon Design System
Status: 🔖 Dev to do
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mackoj @lauthieb @daniel-dumortier @florentlotthepro