Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is "arbitrary" actually used? #365

Open
elmarco opened this issue Feb 12, 2024 · 3 comments
Open

Is "arbitrary" actually used? #365

elmarco opened this issue Feb 12, 2024 · 3 comments

Comments

@elmarco
Copy link
Contributor

elmarco commented Feb 12, 2024

cargo build --features arbitrary fails currently. And it seems to not be covered by CI.

I am not familiar with that crate, but it seems there are no actual code using it inside IronRDP.

Can we drop it?

@CBenoit
Copy link
Member

CBenoit commented Feb 12, 2024

It’s not yet used, but the intention is to use it for more advanced fuzzing.

@elmarco
Copy link
Contributor Author

elmarco commented Feb 12, 2024

Do you see the build failure too? I don't know why, it seems to have appeared recently (perhaps a rust upgrade?)

@CBenoit
Copy link
Member

CBenoit commented Feb 12, 2024

I got it too. We probably broke it because it’s not checked in the CI yet. But it’s probably not too hard to fix and we can do that when actually moving forward the fuzzing effort. It’s okay to leave it as-it for now. (Worse case I’ll document the feature as unstable when we publish the crate if it’s still not usable.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants