-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test suite: run all notebooks in one or more dirs rather than explicitly named notebooks #325
Comments
@jarmarshall @joefresna Which notebooks should/shouldn't be run by tox? |
I would say run everything (including in subfolders) in:
|
I'm happy with that - stick it on the second release milestone for now I think... |
@jarmarshall How about we migrate all Notebooks other than the user manual and test notebooks to other repos to cut down CI job time? These auxillary repos could have their own CI and could depend on stable versions of MuMoT. |
I think this could be a sensible suggestion since it could also solve another problem, of how to publish new notebooks which are linked from readthedocs, without needing to tag a new release or have readthedocs point to the master branch to get updates? |
Notebooks in separate repos could have their own mybinder links in their READMEs and have requirements.txt files referencing stable versions of MuMoT. We'd still need to curate mybinder links in the README and Sphinx docs for MuMoT itself for Notebooks bundled with the MuMoT package. Disadvantages of unbundling the less general notebooks:
@jarmarshall If you want to go ahead with this have a think about which notebooks you'd want to unbundle and how they could be distributed between repos. |
OK, this is getting overcomplicated IMO - maybe we should revert to keeping the notebooks as is... but if those to be run as tests need to be explicitly included, we could just exclude those that take a long time / are redundant... |
Hmm, with that approach, Notebooks not run during MuMoT CI jobs won't ever be tested against newer versions of MuMoT. If some Notebooks are moved to separate repos then at least the CI for those repos ensures they're been tested against a known version of MuMoT, even if that version isn't the latest. |
Currently explictly list the notebooks to be run in tox.ini. A cleaner approach would be to have
The text was updated successfully, but these errors were encountered: