Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command GEORADIUSBYMEMBER #1252

Open
arpitbbhayani opened this issue Nov 7, 2024 · 3 comments · May be fixed by #1294
Open

Add support for command GEORADIUSBYMEMBER #1252

arpitbbhayani opened this issue Nov 7, 2024 · 3 comments · May be fixed by #1294
Assignees

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the GEORADIUSBYMEMBER command in DiceDB similar to the GEORADIUSBYMEMBER command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@benbarten
Copy link

Hey @arpitbbhayani,

I'd like to pick up this issue. Feel free to assign it to me.

@apoorvyadav1111
Copy link
Contributor

Hi @benbarten , Assigned. Thanks for contributing to DiceDB.

@benbarten
Copy link

A short update on this one:

I'm in the middle of implementing the logic to find members in the radius of a geo hash/member. Parts of this can likely be re-used or even extracted into a generic function as done in Redis. I'm planning to open a draft PR end of this week to align with other contributors on how to implement other geo commands. See this discussion for reference.

@benbarten benbarten linked a pull request Nov 18, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants