Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed MDNs - failed vs error #265

Open
malcomm opened this issue Dec 12, 2016 · 4 comments
Open

Failed MDNs - failed vs error #265

malcomm opened this issue Dec 12, 2016 · 4 comments

Comments

@malcomm
Copy link
Collaborator

malcomm commented Dec 12, 2016

I just ran into something where our failed MDNs have this in them:

Disposition: automatic-action/MDN-sent-automatically;error

The big thing is that I’m pretty sure that should say failed instead of error.

I’m going to go ahead and just assume this to be true. I created a simple unit test that tests the basic core of what we are doing to generate the MDNs:

@Test
public void testFailedMDN() {
    Notification notification = new Notification(NotificationType.Error);
    notification.setExplanation("Your message encountered an error and failed delivery to the target system. Please contact your system administrator.");
    System.out.println(notification);
   
    String dispositionStatus = NotificationHelper.asString(NotificationType.Error);
    System.out.println("dispositionStatus: " + dispositionStatus);
}

The output of this is:

-------------------------------
------=_Part_1_388706379.1481159551117
 
Your message encountered an error and failed delivery to the target system. Please contact your system administrator.
------=_Part_1_388706379.1481159551117
content-type: message/disposition-notification
 
Disposition: automatic-action/MDN-sent-automatically;error
 
------=_Part_1_388706379.1481159551117--
 
asString: error
 
-------------------------------

Any help on this?
@gm2552
Copy link

gm2552 commented Dec 13, 2016

Validated that RFC 3798 does not define a disposition of error. The disposition should be "failed" as listed in section 4 of RFC3798.

malcomm pushed a commit that referenced this issue Dec 13, 2016
#265 - Supported failed MDNs per specification
2f5e648
gm2552 pushed a commit that referenced this issue Dec 13, 2016
Merge pull request #266 from DirectProject/failed-mdn-issue-265
f33c450 
#265 - Supported failed MDNs per specification
@malcomm
Copy link
Collaborator Author

malcomm commented Dec 13, 2016

@gm2552 - any plans for a 2.2.3 or 2.3 release of Agent? I have a pressing issue that would be really good to get this new code for failed MDN types.

@gm2552
Copy link

gm2552 commented Dec 13, 2016 via email

@gm2552
Copy link

gm2552 commented Dec 14, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gm2552 @malcomm