Interested in Contributing

[t-botea]

This project is great and there's tons of sites out there with many others requesting new sites every day. I'm interesting in contributing and adding additional site supports. What's the best way to contribute new sites with regards to guidelines and/or coding style? My thought is to go through the git history and look at supports for new sites i.e. c0ed6bec

I'm also interested in adding test suites to the project. It would make it easier to verify supporting sites still behave as expected. Have this been thought about? I took a quick look into the source code and right now the architecture makes it difficult to add tests and mocks (static objects that depend on other static objects that depend on static methods, so on so on).

[DirtyRacer1337]

Code example can be looked at #79
For codestyle exist .editorconfig and two plugins Microsoft.CodeAnalysis.NetAnalyzers and StyleCop.Analyzers

I thinked about tests, but I got problem with plugin initialization, splitting plugin to provider for Jellyfin/Emby and data graber can solve this.
And yeah architecture is bad, it need lot improvements

[t-botea]

Just to be clear, loading debug build means changing the log level in logging.default.json to Debug. Is there anything else I need to do? And for checking errors in logs, you're looking in the Inspect window under Console panel?

[DirtyRacer1337]

I made like this, and messages appear in regular jelly logs

logging.default.json

{
  "Serilog": {
    "MinimumLevel": {
      "Default": "Information",
      "Override": {
        "Microsoft": "Warning",
        "System": "Warning",
        "PhoenixAdult": "Debug",
        "ThePornDB": "Debug"
      }
    }
  }
}

I don't know how to load debug build to Emby, better use Jellyfin for it, here all files you need in plugin folder

FlareSolverrSharp.dll
HtmlAgilityPack.dll
HttpClient.Caching.dll
MihaZupan.HttpToSocks5Proxy.dll
PhoenixAdult.dll
PhoenixAdult.pdb

And don't forget it should be debug build, not release

[t-botea]

Yep, I'm using Jellyfin now. Trying to set up my dev environment so apologies for questions. I've worked in mobile development and management for years so this is new (and exciting) for me.

I've tried to load debug build and restarting my Jellyfin server. I see it under my Plugins but it says it's unsupported, any reason why?

[t-botea]

And to make sure my development workflow is the same as yours, after making changes, you build the .dll, import to plugins, and verify changes inside Jellyfin Web UI?

[DirtyRacer1337]

I think you should put all dll's inside subfolder, like PhoenixAdult

Yeah just drop PhoenixAdult.dll and check how it work as user should do it