Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving vanity returns error #313

Closed
3urobeat opened this issue Jun 26, 2023 · 3 comments · Fixed by #314 · May be fixed by #315
Closed

Resolving vanity returns error #313

3urobeat opened this issue Jun 26, 2023 · 3 comments · Fixed by #314 · May be fixed by #315

Comments

@3urobeat
Copy link
Contributor

3urobeat commented Jun 26, 2023 •
edited
Loading

Hey! Resolving the vanity of a user returns an error when attempting to create a SteamID object:

TypeError: input.match is not a function
    at new SteamID (.../node_modules/steamcommunity/node_modules/steamid/index.js:72:23)
    at .../node_modules/steamcommunity/classes/CSteamSharedFile.js:148:24
    at .../node_modules/steamcommunity/components/helpers.js:109:4
@3urobeat 3urobeat changed the title Fetching sharedfile owner returns error Resolving vanity returns error Jun 26, 2023
3urobeat added a commit to 3urobeat/node-steamcommunity that referenced this issue Jun 26, 2023
@3urobeat
Fix resolving vanity DoctorMcKay#313
0fc1120
@3urobeat 3urobeat mentioned this issue Jun 26, 2023
Merged
@3urobeat
Copy link
Contributor Author

The oversight occurred in 4723bd9 & 27d2daa, so it's my fault. Sorry for not noticing earlier

@DoctorMcKay
Copy link
Owner

👍 Thanks

@3urobeat
Copy link
Contributor Author

I just got bug reports from two users that this still seems to fail when the profile is private.
It looks like Steam does not include the customURL key inside the xml response for private profiles for some reason.

I'll open a PR in a few minutes that should fix this bug as well by parsing the function's url parameter instead of getting it from the XML data.

3urobeat added a commit to 3urobeat/node-steamcommunity that referenced this issue Jun 27, 2023
@3urobeat
Fix resolving vanity for private profiles DoctorMcKay#313
169941b
@3urobeat 3urobeat mentioned this issue Jun 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@DoctorMcKay @3urobeat