Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing an Authority property on ClientCredentialsClient #49

Open
brockallen opened this issue Apr 26, 2023 · 1 comment
Open
Labels
area/access-token-management Issues related to Access Token Management impact/breaking The fix or change will be a breaking one
Milestone

Comments

@brockallen
Copy link
Member

This would be used to automatically access the discovery document to set TokenEndpoint internally (prolly in an IPostConfigureOptions).

@josephdecock
Copy link
Member

Some work in progress is here: joe/wip/authority, but there is more complexity than I initially thought.

The issue comes down to, at what point do we perform discovery? Retrieving the disco document is asynchronous, so just the mechanics of where do you put that async operation is tricky to do without a breaking change. Also, there's potential caching problems - though right now we're only using discovery to set the token endpoint, and that shouldn't ever change.

Still to do in the WIP branch:

  • Need to consider if we want to use discovery cache at all
  • Tests are still failing, and making them pass will require reworking
    management of discovery cache (or its non-cached replacement)
  • xmldoc needs to be written
  • Need to consider how the oidc options interact with the new oauth
    option. Both have an authority, but don't behave the same. On the
    OIDC side, we use the option from the OIDC auth handler.

@damianh damianh transferred this issue from DuendeSoftware/Duende.AccessTokenManagement Nov 17, 2024
@damianh damianh added area/access-token-management Issues related to Access Token Management priority/3 Medium impact/non-breaking The fix or change will not be a breaking one labels Nov 17, 2024
@damianh damianh added impact/breaking The fix or change will be a breaking one priority/4 Low and removed impact/non-breaking The fix or change will not be a breaking one priority/3 Medium priority/4 Low labels Dec 2, 2024
@damianh damianh added this to the atm-4.0.0 milestone Dec 2, 2024
@damianh damianh removed their assignment Dec 2, 2024
@damianh damianh modified the milestones: atm-4.0.0, atm-future-major, atm-future Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/access-token-management Issues related to Access Token Management impact/breaking The fix or change will be a breaking one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants