Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ClientCredentialsTokenManagementBuilder.Services a public property. #73

Open
goldsam opened this issue Dec 13, 2024 · 0 comments
Open
Labels
area/access-token-management Issues related to Access Token Management impact/non-breaking The fix or change will not be a breaking one
Milestone

Comments

@goldsam
Copy link

goldsam commented Dec 13, 2024

To enhance the extensibility of this library, consider making ClientCredentialsTokenManagementBuilder.Services a public property.

There are situations where it is desirable to override a subset of the services configured by AddClientCredentialsTokenManagement. In these cases, it would be ideal to support custom AddXXX() extension method to ClientCredentialsTokenManagementBuilder. However, this would require access to the currently private IServiceCollection member.

This change would be consistent with many other DI builders available in core packages, including:

@josephdecock josephdecock added area/access-token-management Issues related to Access Token Management impact/non-breaking The fix or change will not be a breaking one labels Dec 16, 2024
@josephdecock josephdecock added this to the atm-future milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/access-token-management Issues related to Access Token Management impact/non-breaking The fix or change will not be a breaking one
Projects
None yet
Development

No branches or pull requests

2 participants