Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the canonical copy of the CWL conformance tests #82

Closed
mr-c opened this issue Jul 22, 2019 · 3 comments · Fixed by #89
Closed

Use the canonical copy of the CWL conformance tests #82

mr-c opened this issue Jul 22, 2019 · 3 comments · Fixed by #89
Assignees

Comments

@mr-c
Copy link
Contributor

mr-c commented Jul 22, 2019

https://github.com/common-workflow-language/common-workflow-language is the canonical location for the CWL v1.0 conformance tests

@dleehr dleehr self-assigned this Jul 22, 2019
@dleehr
Copy link
Member

dleehr commented Jul 22, 2019

Thanks @mr-c! I updated to using the v1.0.1 release on 82-canonical-conformance-tests and have fewer failures now.

105 tests passed, 3 failures, 0 unsupported features
1 tool tests failed

However I only find 2 failures in the output:

I know for example that many of the DockerRequirement features are not supported (#12):

# Dictionary of supported features.
# Not yet complete, only checks features of DockerRequirement
supported_features = {
'DockerRequirement': ['class', 'dockerPull']
}
def check_requirements(self):
for feature in self.supported_features:
requirement, is_required = self.get_requirement(feature)
if requirement and is_required:
for field in requirement:
if not field in self.supported_features[feature]:
raise UnsupportedRequirement('Error: feature {}.{} is not supported'.format(feature, field))

so I would expect this one to fail:

Test [94/108] Test dockerOutputDirectory
Test [95/108] Test hints with $import

but it doesn't appear to. Any idea how to root out this or other failures?

@mr-c
Copy link
Contributor Author

mr-c commented Jul 22, 2019

When a test fails, I re run it manually using the provided command line without --quiet and adding engine specific debugging options like --debug or similar

@dleehr
Copy link
Member

dleehr commented Jul 23, 2019

I would expect this one to fail ... but it doesn't appear to. Any idea how to root out this or other failures?

This was caused by using a 2-year old release of https://github.com/common-workflow-language/common-workflow-language. Updating to today's release (v1.0.2) runs a total of 197 tests for 1.0 with 191 passing. And the failures are all accounted for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants