-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Update macOS Runner (Latest) #54
Conversation
f3aa671
to
1528ec2
Compare
The old `macos-11` image is now removed. Update to running release `macos-latest`.
@lucafedeli88 the table test seems to need a tolerance review on the last significant digits. Can you help with this? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ax3l ,
thanks for this PR!
Precision for the failing test (test_picsar_tables.cpp
) is set by these two variables
//Tolerance for double precision calculations
const double double_tolerance = 1.0e-12;
//Tolerance for single precision calculations
const float float_tolerance = 1.0e-5;
We may try to increase the tolerance by a small factor (e.g., 2 or 5) and see if the tests pass.
I can do that if you want!
Besides of that, the PR looks good to me: as soon as the tests pass we can merge it.
Hi @lucafedeli88,
Thanks a lot - I pushed a few updates, but happy if you can take it over for the tolerances :) |
Ah, the tolerances are not used in the tests that actually fail:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry! I didn't know that the failing test actually used BOOST_CHECK_EQUAL
.
I think that your change makes sense here.
Thanks for this PR!
The old
macos-11
image is now removed. Update to running releasemacos-latest
.picsar_tables
test: some numerical values vary on near-machine precision but compare without an epsilon