Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required thrust calculation is off #731

Open
Kaze-Kami opened this issue Dec 3, 2022 · 5 comments
Open

Required thrust calculation is off #731

Kaze-Kami opened this issue Dec 3, 2022 · 5 comments

Comments

@Kaze-Kami
Copy link

Coriolis does consider max ship mass given thruster grade, thought this calculation is not correct.

Consider the following Example Build. It requires grade 7 (at least B I think) thrusters to work, not 6A as shown as 'ok' in the outfitter.

@Sid127
Copy link

Sid127 commented Dec 7, 2022

I don't see the issue here, if I'm being honest. The max mass of the ship, aka the Laden mass, is 1802 T, while the max mass of the 6A thrusters is 2160T

@Kaze-Kami
Copy link
Author

I'm aware of the numbers (It did look good to me too...), still the game wouldn't let me build that ship ('Module will exceed maximum mass' when adding the shield gen iirc). I'll double check that I didn't mess something else up and let you know asap.

@Kaze-Kami
Copy link
Author

Alright I did some checking:
First of: The Example build uses 6A Thrusters, which is just fine, you're right on that. I did change that at some point and just forgot about it, hence posting the 'wrong' build.
The 'real' issue is that Coriolis shows 6D (or even 6E) thrusters as usable (these were on the original build I tried to buy in game), but if you look at it then (Build with 6D Thrusters): Thrusters maximum mass is 1620T while laden mass is 1778T.

@Sid127
Copy link

Sid127 commented Dec 8, 2022

Now that's an issue I can get behind :D
I'll see how it's done, and include the fix in an update soon-ish. Lots of module changes are pending at the moment anyway

@alex-williams
Copy link
Collaborator

The calculation as to whether Thrusters can be fitted or not, needs to look at Laden Mass, rather than Unladen Mass, to make the decision. Unladen Mass of this build is well within the Thrusters capability, which is why Coriolis allows them to be added to the build, but the game uses the Laden Mass (Which makes sense, or you load up with cargo and suddenly your thrusters don't work...). I'll look into this in the next few days and modify the way the calculation is done, to take Laden Mass into account.

@alex-williams alex-williams pinned this issue Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants