Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the webkit bioid array to each yaml? #54

Open
j-ro opened this issue Dec 20, 2014 · 1 comment
Open

Moving the webkit bioid array to each yaml? #54

j-ro opened this issue Dec 20, 2014 · 1 comment

Comments

@j-ro
Copy link
Collaborator

j-ro commented Dec 20, 2014

Thoughts on moving the requires_webkit constant from https://github.com/EFForg/congress-forms/blob/69eff91202d10b40de6fb3fdc358a2f5b20481f2/config/constants.rb and putting it in each YAML file instead?

Makes more sense in some ways, and allows us to incorporate this constant with our git pulls from the contact congress repo, instead of having to restart everything when this changes.

Also, helpful for testing, so you understand why a yaml may not be working in phantomjs if you're testing that way.

@Hainish
Copy link
Member

Hainish commented Feb 2, 2015

This relates to the discussion on whether the YAML files should be tied to a particular implementation, here: unitedstates/contact-congress#1402 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants