Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P-class window settings #14

Open
DavidGarfinkle opened this issue Jun 9, 2017 · 0 comments
Open

P-class window settings #14

DavidGarfinkle opened this issue Jun 9, 2017 · 0 comments

Comments

@DavidGarfinkle
Copy link
Collaborator

P1, P2, and P3 don't currently support filtering by pattern or source window size like S1, S2, W1, and W2 do. This is more or less because the algorithms themselves don't rely on a window whereas the design of the SW algorithms (specifically the pre-computation of their K-tables) use pattern and source windows.

I'm suggesting we include a result filter so the settings usage across all algorithms is consistent. We could modify the algorithms a bit to possibly increase runtime by including window settings, but I suspect this wouldn't have any noticeable effect on the current runtime, judging by the way they currently work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant