Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPID reference in EUCC #10

Open
bartbink opened this issue Oct 30, 2024 · 3 comments
Open

LPID reference in EUCC #10

bartbink opened this issue Oct 30, 2024 · 3 comments

Comments

@bartbink
Copy link

bartbink commented Oct 30, 2024

https://github.com/EWC-consortium/eudi-wallet-rulebooks-and-schemas/blob/main/data-schemas/ds001-eu-company-certificate.json

in the EUCC it states:

"legalName": {
              "description": "Legal person official name as in LPID",

it would be nice to also refer to the LPID with the EUID:

"identifier": {
              "description": "EUID of the company as in LPID",

@michelleludovici1
Copy link
Collaborator

michelleludovici1 commented Nov 19, 2024

Actually, don't refer to the LPID at all in the description. Maybe we could use $ref tags to refer to the attribute in another schema?
Example: "$ref": "https://raw.githubusercontent.com/bartbink/eudi-wallet-rulebooks-and-schemas/SR-and-PoA/data-schemas/ds004-legal-person-identification-data.json#/properties/issuing_authority"

@bartbink
Copy link
Author

bartbink commented Dec 6, 2024

$ref sounds good to me. I don't know how this works in a credential in this format. That's my shortcoming.

@lalc
Copy link
Contributor

lalc commented Dec 6, 2024

Two comments:

  1. If you refer to LPID, all properties of LPID get inherited.

  2. Using $ref is okay if it's not a private repository. :) It shall point to https://raw.githubusercontent.com/EWC-consortium/eudi-wallet-rulebooks-and-schemas/refs/heads/main/data-schemas/ds004-legal-person-identification-data.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants