Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend staged bundling #245

Open
davenquinn opened this issue Oct 10, 2021 · 1 comment
Open

Frontend staged bundling #245

davenquinn opened this issue Oct 10, 2021 · 1 comment

Comments

@davenquinn
Copy link
Collaborator

Errors like #242 and #244 arise from bundling of frontend code (and in development mode, download/install of node_modules) at runtime. This is a wasteful and error-prone process for the majority of users. It makes startup much slower and less deterministic. However, we do this so we can incorporate lab-specific plugins into the build. It would be useful to accomplish more of the bundling at build time.

To do this, we should probably upgrade to Webpack v5, which has better tools for multistage builds. And then figure out how to keep plugins separate. We could potentially make use of new sparrow-prestart.sh scripts to build user-provided plugins into images, but this probably won't happen for a while.

@davenquinn
Copy link
Collaborator Author

This goes hand-in-hand with #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant