Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tone down sortpom output #338

Closed
gnodet opened this issue Jun 20, 2023 · 6 comments
Closed

Tone down sortpom output #338

gnodet opened this issue Jun 20, 2023 · 6 comments
Assignees

Comments

@gnodet
Copy link
Contributor

gnodet commented Jun 20, 2023

When using spotless to format a number of POMs, I end up with:

[INFO] --- spotless:2.28.0:apply (default) @ core-it-suite ---
[INFO] Up-to-date checking enabled
[INFO] Index file does not exist. Fallback to an empty index
[INFO] Sorting file /var/folders/27/cvb78knj3xbdvty_5406llg40000gn/T/pom5965351127772285323.xml
[INFO] Pom file is already sorted, exiting
[INFO] Sorting file /var/folders/27/cvb78knj3xbdvty_5406llg40000gn/T/pom2262155197844819727.xml
[INFO] Pom file is already sorted, exiting
[INFO] Sorting file /var/folders/27/cvb78knj3xbdvty_5406llg40000gn/T/pom15172041996443537493.xml
[INFO] Pom file is already sorted, exiting
[INFO] Sorting file /var/folders/27/cvb78knj3xbdvty_5406llg40000gn/T/pom16267362389972598028.xml
[INFO] Pom file is already sorted, exiting
[INFO] Sorting file /var/folders/27/cvb78knj3xbdvty_5406llg40000gn/T/pom7652642504318211203.xml
[INFO] Pom file is already sorted, exiting
[INFO] Sorting file /var/folders/27/cvb78knj3xbdvty_5406llg40000gn/T/pom11256884799925871044.xml
[INFO] Pom file is already sorted, exiting
[INFO] Sorting file /var/folders/27/cvb78knj3xbdvty_5406llg40000gn/T/pom17508744454483620454.xml
[INFO] Pom file is already sorted, exiting
[INFO] Sorting file /var/folders/27/cvb78knj3xbdvty_5406llg40000gn/T/pom5276297680844189648.xml
[INFO] Pom file is already sorted, exiting
[INFO] Sorting file /var/folders/27/cvb78knj3xbdvty_5406llg40000gn/T/pom8221381498996836063.xml
[INFO] Pom file is already sorted, exiting
[INFO] Sorting file /var/folders/27/cvb78knj3xbdvty_5406llg40000gn/T/pom15758736795576591383.xml
[INFO] Pom file is already sorted, exiting
...

I'd like to introduce a flag to done down the log to debug instead of info.

@Ekryd
Copy link
Owner

Ekryd commented Jun 20, 2023

Sounds reasonable. Maybe a flag “quiet” that removes all output from the plugin?

@Ekryd
Copy link
Owner

Ekryd commented Jun 29, 2023

Hi! Just wanted to say that I have not forgotten this issue. I’m away at a family vacation at the moment, and so far programming has not been on the menu.

@gnodet
Copy link
Contributor Author

gnodet commented Jun 29, 2023

Hi! Just wanted to say that I have not forgotten this issue. I’m away at a family vacation at the moment, and so far programming has not been on the menu.

No problem, enjoy your vacation time !

@Ekryd Ekryd self-assigned this Jul 1, 2023
@create-issue-branch
Copy link

Branch issue-338-Tone_down_sortpom_output created!

Ekryd added a commit that referenced this issue Jul 1, 2023
Add a quiet flag to disable plugin info output (fixes #338)
@Ekryd
Copy link
Owner

Ekryd commented Jul 1, 2023

I created a branch for the quiet flag. (I refactored the code a bit)
@gnodet, can you submit a PR for the branch with an integration test? Similar functionality as maven-plugin/src/it/four-spaces-indent

@Ekryd Ekryd closed this as completed in e6a5995 Jul 24, 2023
@Ekryd Ekryd reopened this Jul 24, 2023
@Ekryd
Copy link
Owner

Ekryd commented Jul 24, 2023

Hi @gnodet !
I have just released version 3.3.0 of the plugin with the new quiet flag.
Please try it out and see if it works for you

@Ekryd Ekryd closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants