Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Normalization of Input/Output in SAE Implementation #34

Open
tatsuropfgt opened this issue Nov 13, 2024 · 0 comments
Open

Missing Normalization of Input/Output in SAE Implementation #34

tatsuropfgt opened this issue Nov 13, 2024 · 0 comments

Comments

@tatsuropfgt
Copy link

Scaling and evaluating sparse autoencoders(Gao et al. 2024) mentions that normalization is applied to the input/output of SAEs in 2.1 Setup.

We subtract the mean over the d_model dimension and normalize all inputs to unit norm, prior to passing to the autoencoder (or computing reconstruction errors)."

However, I could not find such an implementation within this repository.
I would like to understand whether this is a mistake in this implementation, if there is a specific reason for not performing the normalization, or if I might have overlooked something.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant