generating-transactions.md is outdated

[bluezdot]

Hi,
I've faced with the issue that Generating Transactions example is outdated. https://github.com/Emurgo/cardano-serialization-lib/blob/master/doc/getting-started/generating-transactions.md

Some logic was changed and method have been renamed.

• coins_per_utxo_word -> coins_per_utxo_bytes
• CardanoWasm.hash_transaction is remove
• ....

I am getting an error on create txHash for setting vkeyWitness. I'm trying to replace CardanoWasm.TransactionHash by:

• const txHash = CardanoWasm.TransactionHash.from_hex(txBody.to_hex());
  but get this error:

[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "JsValue("Deserialization failed in TransactionHash because: Invalid cbor: expected tuple 'hash length' of length 32 but got length Len(188).")".] {
  code: 'ERR_UNHANDLED_REJECTION'

[bluezdot]

@vsubhuman can you help with this?

[vsubhuman]

@vsubhuman can you help with this?

I am getting an error on create txHash for setting vkeyWitness. I'm trying to replace CardanoWasm.TransactionHash by:

const txHash = CardanoWasm.TransactionHash.from_hex(txBody.to_hex());
but get this error:

All from_hex functions are for deserialising the instance of the type itself from it's HEX version. In your example the TransactionHash itself is a library type, so the from_hex function expects you to pass the string with the transaction hash in it, not the transaction itself as hex.

To calculate tx hash from a transaction use function:

FixedTransaction.from_hex(txHexString).transaction_hash()

See the difference that in the second case you are deserialising the transaction itself using from_hex and then calling a utility function for calculations.

[vsubhuman]

@bluezdot , see the "Examples" section from the latest major release description: https://github.com/Emurgo/cardano-serialization-lib/releases/tag/13.0.0

[bluezdot]

@bluezdot , see the "Examples" section from the latest major release description: https://github.com/Emurgo/cardano-serialization-lib/releases/tag/13.0.0

I tried this and it passed the error.
But the tx failed when I submit with response:

BlockfrostServerError: {"contents":{"contents":["DecoderErrorDeserialiseFailure \"Shelley Tx\" (DeserialiseFailure 0 \"expected list len or indef\")","DecoderErrorDeserialiseFailure \"Shelley Tx\" (DeserialiseFailure 0 \"expected list len or indef\")","DecoderErrorDeserialiseFailure \"Shelley Tx\" (DeserialiseFailure 0 \"expected list len or indef\")","DecoderErrorDeserialiseFailure \"Shelley Tx\" (DeserialiseFailure 0 \"expected list len or indef\")","DecoderErrorDeserialiseFailure \"Shelley Tx\" (DeserialiseFailure 0 \"expected list len or indef\")","DecoderErrorDeserialiseFailure \"Shelley Tx\" (DeserialiseFailure 0 \"expected list len or indef\")"],"tag":"TxCmdTxReadError"},"tag":"TxSubmitFail"}

[bluezdot]

@vsubhuman, I'm trying to just build a tx to transfer token -> sign -> submit.
Can you please take a look into my build tx code and let me know if anything wrong? You can skip the keygen phase

import * as CardanoWasm from "@emurgo/cardano-serialization-lib-nodejs";
import {getBlockFrostApi} from "../../utils";
import {mnemonicToEntropy} from "@meshsdk/core";
import {FixedTransaction} from "@emurgo/cardano-serialization-lib-nodejs";

function harden(num: number): number {
    return 0x80000000 + num;
}

const AMOUNT_SEND = '990750';
const RECEIVER = 'addr_test1qpcv6j0wl3mlypw4udf2z74v4k8reklslx8020q0qzqc0wxmmnlwawkxjzctt94jmpcqysmt8xy35dm4hgyk3yua2uqsh49j95'
const utxos = [
    {
        "address": "addr_test1qr3nhq5hu88xjls8kyk790rcz2qt43aee9yuvx2gjn5msgfjwcw036s7adnz3f8ufl85guxkhz3cvv4znrvy7rzmv0qquff93j",
        "tx_hash": "53ceb3b3417dd6d0e1e7e130bbd29414fb1fc96cf2c3c988fc0a345083c5cf98",
        "tx_index": 1,
        "output_index": 1,
        "amount": [
            {
                "unit": "lovelace",
                "quantity": "9998829351"
            }
        ],
        "block": "3b93fad2e37dff76aa9c71847fd9f3bb357de25419f396656dc6f2f4ed6bf15f",
        "data_hash": null,
        "inline_datum": null,
        "reference_script_hash": null
    }
]

// 1. Keyring
async function main() {
    const mnemonic = 'YOUR_MNEMONIC';
    const entropy = mnemonicToEntropy(mnemonic);
    const rootKey = CardanoWasm.Bip32PrivateKey.from_bip39_entropy(
        Buffer.from(entropy, 'hex'),
        Buffer.from(''),
    );
    const accountKey = rootKey
        .derive(harden(1852))
        .derive(harden(1815))
        .derive(harden(0));
    const paymentPrvKey = accountKey
        .derive(0)
        .derive(0).to_raw_key();
    const paymentPubKey = accountKey
        .derive(0)
        .derive(0)
        .to_public();
    const stakeKey = accountKey
        .derive(2) // chimeric
        .derive(0)
        .to_public();
    const baseAddress = CardanoWasm.BaseAddress.new(
        CardanoWasm.NetworkInfo.testnet_preprod().network_id(),
        CardanoWasm.Credential.from_keyhash(paymentPubKey.to_raw_key().hash()),
        CardanoWasm.Credential.from_keyhash(stakeKey.to_raw_key().hash()),
    );
    const address = baseAddress.to_address().to_bech32();

// 2. Build Tx
    const linearFee = CardanoWasm.LinearFee.new(
        CardanoWasm.BigNum.from_str('44'), // get from blockfrost api
        CardanoWasm.BigNum.from_str('155381') // get from blockfrost api
    );
    const txBuilderConfig = CardanoWasm.TransactionBuilderConfigBuilder.new()
        .fee_algo(linearFee)
        .coins_per_utxo_byte(CardanoWasm.BigNum.from_str('4310')) // coins_per_utxo_word/8 ?
        .pool_deposit(CardanoWasm.BigNum.from_str('500000000')) // get from blockfost api
        .key_deposit(CardanoWasm.BigNum.from_str('2000000')) // get from blockfrost api
        .ex_unit_prices(
            CardanoWasm.ExUnitPrices.new(
                CardanoWasm.UnitInterval.new(CardanoWasm.BigNum.from_str('577'), CardanoWasm.BigNum.from_str('10000')), // get from blockfrost api
                CardanoWasm.UnitInterval.new(CardanoWasm.BigNum.from_str('721'), CardanoWasm.BigNum.from_str('10000000')), // get from blockfrost api
            ),
        )
        .max_value_size(5000) // get from blockfrost api
        .max_tx_size(16384) // get from blockfrost api
        .build()
    const txBuilder = CardanoWasm.TransactionBuilder.new(txBuilderConfig)

    const txInput = CardanoWasm.TransactionInput.new(
        CardanoWasm.TransactionHash.from_hex(utxos[0].tx_hash),
        utxos[0].output_index
    );

    const txOutput = CardanoWasm.TransactionOutput.new(
        CardanoWasm.Address.from_bech32(RECEIVER),
        CardanoWasm.Value.new(CardanoWasm.BigNum.from_str(AMOUNT_SEND))
    );

    const txOutputChange = CardanoWasm.TransactionOutput.new(
        baseAddress.to_address(),
        CardanoWasm.Value.new(CardanoWasm.BigNum.from_str((BigInt(utxos[0].amount[0].quantity) - BigInt(AMOUNT_SEND) - BigInt(linearFee.constant().to_str())).toString()))
    )

    const txUnspentOutput = CardanoWasm.TransactionUnspentOutput.new(
        txInput,
        txOutputChange
    );

    const unspentOutputs = CardanoWasm.TransactionUnspentOutputs.new();
    unspentOutputs.add(txUnspentOutput)

    const wasmChangeConfig = CardanoWasm.ChangeConfig.new(CardanoWasm.Address.from_bech32(address))
    txBuilder.add_output(txOutput)
    txBuilder.add_inputs_from_and_change(unspentOutputs, CardanoWasm.CoinSelectionStrategyCIP2.LargestFirstMultiAsset, wasmChangeConfig)

    const transaction = txBuilder.build_tx()

    // 3. Add witness
    // const txHash = CardanoWasm.TransactionHash.from_hex(_transaction.to_hex());
    const txHash = FixedTransaction.from_hex(transaction.to_hex()).transaction_hash();
    const vkeyWitnesses = CardanoWasm.Vkeywitnesses.new();
    const vkeyWitness = CardanoWasm.make_vkey_witness(txHash, paymentPrvKey);
    vkeyWitnesses.add(vkeyWitness);
    transaction.witness_set().set_vkeys(vkeyWitnesses)

    // 4. Sign tx
    const signedMsg = paymentPrvKey.sign(transaction.to_bytes());
    const api = getBlockFrostApi(true);

    // 5. Submit tx
    const tx = await api.txSubmit(signedMsg.to_bytes());
}

main()