Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the library ExcelNumberFormat for our own implementation #109

Open
rliberoff opened this issue Apr 24, 2024 · 0 comments
Open

Replace the library ExcelNumberFormat for our own implementation #109

rliberoff opened this issue Apr 24, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rliberoff
Copy link
Member

Currently, the Excel connector that reads Excel files and transforms them into Markdown for AI LLMs uses a library called ExcelNumberFormat. It is available here: https://github.com/andersnm/ExcelNumberFormat

The issue is this library is rather old (no new updates since 2020) and belongs to a source that is not really know. The code of this library is quite simple, so we should be able to create an improved and modernized copy (using the latest features of C# language) and take control of the implementation. Obviously, we should mention the original author in the corresponding README.md.

I think the best place to code this is in Encamina.Enmarcha.Core. I would not bind the name of the code to Excel, and instead name it based on the ECMA-376 standard 👉🏻 https://ecma-international.org/publications-and-standards/standards/ecma-376/

@rliberoff rliberoff added enhancement New feature or request good first issue Good for newcomers labels Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant